[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: sunpinyin - Simplified Chinese Input Method from SUN

On 星期三 30 6月 2010 21:57:27 Thomas Goirand wrote:
> Hi Liang Guo,
Hi, Thomas, 
(add CC to debian-mentors and pkg-ime-devel)

Thanks for your review. 
> Here's what I can say when I review your package.
> * debian/copyright:
> Please add a copyright notice for the LGPL-2.1.
Which part of LGPL-2.1 should I add ? the end part of LGPL.LICENSE is the same 

> * debian/control:
> You did a confusion between Maintainer: and Uploaders: field. If you write:
> Maintainer: Liang Guo <bluestonechina@gmail.com>
> you assume the maintainer-ship responsability for the package in Debian.
> If you are doing an RFS, then it should be you in this field. Besides
> this, you are more than welcome to use UTF-8 and write your name in
> Simplified Chinese this file, I believe.
> Uploaders:, if I sponsor the package, would be me, and you don't want to
> fill this field. As I didn't sponsor a package yet, I'll have to find
> out how to manage this field! :)
Maintainer is the owner of this package. for sunpinyin is a input method 
package,  I hope this packageCollaborative maintenanced by IME Packaging Team, 
so I set IME Packaging Teamas as the Maintainer, and me as the Uploaders. I 
reference developers-reference[1] to set these fields. 

For sponsor a package, this  FAQ[2] may help. Develpers-reference have related 
topics[3] too. 

> You wrote build-depends on debhelper  (>= 7.0.50~) and quilt (>=
> 0.46-7~), do you need specificities on specific versions currently in
> Debian? If yes, which one?

I use dh_make to generate debian/*, ande debian/control comes with build-
depends on debhelper, if build-depends on debhelper removed, lintian reports 
package-uses-debhelper-but-lacks-build-depends, and it will fail to build in 
my pbuilder environment. 

My debian/rules invokes dh_quilt_patch and dh_quilt_unpatch when build and 
clean, those commands are in quilt, so I should have build-depends on quilt 

> I never seen/packaged a software using the CDDL type of license. Do you
> know if this is a know license that is ok in Debian?
CDDL is a commonly used open source license, openoffice, glassfish, netbeans and 
many other packages in debian use CDDL too.  Thomas Koch even raise a bug to 
ask base-files include CDDL[5]
> * debian/docs:
> You are including LGPL.LICENSE in the list of files install, even though
> in your debian/copyright, you mention the path to the LGPL-2.1. In other
> words:
> - Remove LGPL.LICENSE from debian/docs
> - Add the copyright notice for the LGPL (that's a kind of short version
> of the big file in /usr/share/common-licenses/LGPL-2.1) in your
> debian/copyright.
> - I don't think packaging COPYING in your binaries is useful. Remove it
> also from debian/docs. 
OK, I'll remove LGPL.LICENSE and COPYING from debian/docs. Shoud 
OPENSOLARIS.LICENSE be removed too ?  for debian/copyright have included it. 
> * README.Debian
> Do you think you could package the files here:
> wget http://googlecode.debian.net/p/open-gram/dict.utf8.tar.bz2
> wget http://googlecode.debian.net/p/open-gram/lm_sc.t3g.arpa.tar.bz2
> into specific Debian packages on which you would depend?
> What are the licenses of lm_sc.t3g.arpa.tar.bz2 and dict.utf8.tar.bz2?
> Would the library continue to work without these files?
lm_sc.t3g.arpa.tar.bz2 and dict.utf8.tar.bz2 is licensed under Creative 
Commons 3.0 BY-SA, CC-by-SA 3.0 is DFSG-compatible[6], I want to package it 
latter, so I write debian/README.Debian as a transient proposal. 

> * debian/rules
> - Instead of invoking `pwd` on each files, use $(CURDIR).
Its my mistake, I'll correct this problem in next upload. 
> * I don't think you need to name the directories in the *.dirs if you
> are installing things in it. The directory will be created automatically.
There is no file in /usr/lib/sunpinyin/data after installation, it is used for 
compiled LM and DICD data, and I hope it can be automatically remove if it is 
empty when remove libsunpinyin3 or sunpinyin-utils. 
> (ogiz) dnarioG samohT
> P.S: I'm up-side down because I just drove the full day from 郑州 to 上海...
[1] http://www.debian.org/doc/developers-reference/pkgs.html#collaborative-

[2] http://people.debian.org/~mpalmer/debian-mentors_FAQ.html

[3] http://www.debian.org/doc/developers-reference/beyond-



[6] http://wiki.debian.org/DFSGLicenses
Liang Guo

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply to: