Re: RFS: gflags
On Thu, Apr 29, 2010 at 1:44 PM, Ehren Kret <ehren.kret@gmail.com> wrote:
> I am looking for a sponsor for my package "gflags".
I'm not sponsoring, but here is a review:
You can remove the boilerplate from debian/rules.
The upstream README doesn't add any useful information, no need to ship it.
The upstream NEWS file is empty, no need to ship it. The upstream
ChangeLog looks like it should be named NEWS instead:
http://www.gnu.org/prep/standards/standards.html#NEWS-File
http://www.gnu.org/prep/standards/standards.html#Change-Logs
The library package will almost always be automatically installed so
it doesn't need as detailed a description as the -dev package.
Some gcc warnings to send upstream:
g++ -DHAVE_CONFIG_H -I. -I. -I./src -I./src -Wall -Wwrite-strings
-Woverloaded-virtual -Wno-sign-compare -g -O2 -c -o gflags_unittest.o
`test -f 'src/gflags_unittest.cc' || echo './'`src/gflags_unittest.cc
src/gflags_unittest.cc:95: warning: dereferencing type-punned pointer
will break strict-aliasing rules
src/gflags_unittest.cc:100: warning: dereferencing type-punned pointer
will break strict-aliasing rules
src/gflags_unittest.cc:109: warning: dereferencing type-punned pointer
will break strict-aliasing rules
src/gflags_unittest.cc:119: warning: dereferencing type-punned pointer
will break strict-aliasing rules
src/gflags_unittest.cc:120: warning: dereferencing type-punned pointer
will break strict-aliasing rules
src/gflags_unittest.cc:121: warning: dereferencing type-punned pointer
will break strict-aliasing rules
src/gflags_unittest.cc:124: warning: dereferencing type-punned pointer
will break strict-aliasing rules
src/gflags_unittest.cc:138: warning: dereferencing type-punned pointer
will break strict-aliasing rules
src/gflags_unittest.cc:149: warning: dereferencing type-punned pointer
will break strict-aliasing rules
lintian complaints to fix:
I: gflags source: binary-control-field-duplicates-source field
"section" in package libgflags0
I: libgflags-dev: possible-documentation-but-no-doc-base-registration
I: libgflags0: spelling-error-in-binary ./usr/lib/libgflags.so.0.0.0
helpfull helpful
I: libgflags0: spelling-error-in-binary
./usr/lib/libgflags_nothreads.so.0.0.0 helpfull helpful
X: libgflags0: shlib-calls-exit usr/lib/libgflags.so.0.0.0
X: libgflags0: shlib-calls-exit usr/lib/libgflags_nothreads.so.0.0.0
I: libgflags0: no-symbols-control-file usr/lib/libgflags_nothreads.so.0.0.0
I: libgflags0: no-symbols-control-file usr/lib/libgflags.so.0.0.0
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: