Re: RFS: keynav (updated package)
Hi Wen-Yen Chuang--
On 04/04/2010 04:29 AM, Wen-Yen Chuang wrote:
I am looking for a sponsor for the new version 0.20100403.2754-1
of my package "keynav". (Programming language: C)
Sorry it took me a while to review this. Your package looks good! I'm
glad you worked out the config file issues with upstream. A couple notes:
a package structuring suggestion, which you're free to take or leave, is
that you could minimize the rules file to just this:
-----------------
#!/usr/bin/make -f
%:
dh $@
override_dh_clean:
dh_clean keynav_version.h
-----------------
This change would require that you create a versioned build-dependency
on debhelper (>= 7.0.50~), and you'd need to add a file
debian/keynav.manpages that contains a single line:
debian/keynav.1
I think you'd also want to add #DEBHELPER# as the last line of
debian/preinst. See
http://lintian.debian.org/tags/maintainer-script-lacks-debhelper-token.html
The minimized debian/rules seems good to me because you'd get to to rely
on updated versions of debhelper doing the Right Thing.
if you're concerned about the versioned build-dependency making
backports difficult, backports.org provides a solid backported version
of debhelper for lenny that can satisfy this b-d.
About contributing back to upstream:
Have you suggested to Jordan that "make clean" should remove
keynav_version.h as well? Or that profiling should maybe not be turned
on by default? Have you offered your manpage back so that Jordan can
keep it in sync as the code changes?
Let me know what you think about these ideas. I'm looking forward to
seeing this in debian!
Regards,
--dkg
Reply to: