[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libconfig



On Tue, Apr 13, 2010 at 03:41:06PM +0200, José Luis Tallón wrote:
> Dear mentors,
> 
> I am looking for a sponsor for my package "libconfig".
> This release makes available a new upstream version
> 
> * Package name    : libconfig
>   Version         : 1.4.3-1
>   Upstream Author : Mark A Lindner
> * URL             : http://www.hyperrealm.com/libconfig/
> * License         : LGPL-2.1
>   Section         : libs

Hmm, according to your watch file there is a newer version available.

Is there a reason you don't use debhelper 7? I mean, you don't have to
but the change is simple and since you updated the packaging wrt source
format and policy... Attached diff applied seems to build the same
binaries (but please double-check).

I'm not very familiar with shared libraries to be honest. Why don't you
provide versioned symbols? And did you check for API/ABI breakage --
just to be sure no binNMUs are needed?

Hauke
diff -Nru libconfig-1.4.3/debian/compat libconfig-1.4.3/debian/compat
--- libconfig-1.4.3/debian/compat	2010-04-13 15:00:40.000000000 +0200
+++ libconfig-1.4.3/debian/compat	2010-04-13 16:35:04.000000000 +0200
@@ -1 +1 @@
-5
+7
diff -Nru libconfig-1.4.3/debian/control libconfig-1.4.3/debian/control
--- libconfig-1.4.3/debian/control	2010-04-13 14:30:45.000000000 +0200
+++ libconfig-1.4.3/debian/control	2010-04-13 16:42:00.000000000 +0200
@@ -1,7 +1,8 @@
 Source: libconfig
 Priority: optional
 Maintainer: Jose Luis Tallon <jltallon@adv-solutions.net>
-Build-Depends: debhelper (>= 5), autotools-dev, texinfo, texlive, ghostscript
+Build-Depends: debhelper (>= 7.0.50), autotools-dev (>= 20100122.1), texinfo,
+ texlive, ghostscript
 Standards-Version: 3.8.4
 Homepage: http://www.hyperrealm.com/libconfig/
 Section: libs
diff -Nru libconfig-1.4.3/debian/rules libconfig-1.4.3/debian/rules
--- libconfig-1.4.3/debian/rules	2010-04-13 14:59:19.000000000 +0200
+++ libconfig-1.4.3/debian/rules	2010-04-13 16:55:39.000000000 +0200
@@ -1,118 +1,11 @@
 #!/usr/bin/make -f
-# -*- makefile -*-
-# Sample debian/rules that uses debhelper.
-# This file was originally written by Joey Hess and Craig Small.
-# As a special exception, when this file is copied by dh-make into a
-# dh-make output file, you may use that output file without restriction.
-# This special exception was added by Craig Small in version 0.37 of dh-make.
 
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
 
-LIBS = $(shell grep '^Package: lib' debian/control | egrep -v '(-doc|-dev)' | sed -e 's@Package: @@' )
-
-# These are used for cross-compiling and for saving the configure script
-# from having to guess our platform (since we know it already)
-DEB_HOST_GNU_TYPE   ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
-DEB_BUILD_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
-
-#include /usr/share/quilt/quilt.make
-
-CFLAGS = -Wall -g
-
-ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
-	CFLAGS += -O0
-else
-	CFLAGS += -O2
-endif
-
-# shared library versions, option 1
-version=8
-major=8
-minor=1
-
-
-config.status: configure
-	dh_testdir
-	test -e config.sub -a -L config.sub || \
-		ln -sf /usr/share/misc/config.sub config.sub
-	test -e config.guess -a -L config.guess || \
-		ln -sf /usr/share/misc/config.guess config.guess
-
-	./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) \
-		--prefix=/usr \
-		--mandir=\$${prefix}/share/man \
-		--infodir=\$${prefix}/share/info 
-	CFLAGS="$(CFLAGS)" LDFLAGS="-Wl,-z,defs"
-
-configure:	patch
-	$(RM) debian/libconfig8.info debian/shlibs
-
-build: build-stamp
-build-stamp:  config.status
-	dh_testdir
-
-	# Add here commands to compile the package.
-	$(MAKE)
+%:
+	dh $@ --with autotools_dev
 
+override_dh_auto_build:
+	dh $@ --with autotools_dev --parallel
 	$(MAKE) -C doc pdf
-	touch $@
-
-clean:	unpatch
-	dh_testdir
-	dh_testroot
-
-	[ ! -f Makefile ] || $(MAKE) distclean
-
-	rm -f build-stamp
-
-	$(RM) config.guess config.sub config.log
-	dh_clean 
-
-install: build
-	dh_testdir
-	dh_testroot
-	dh_clean -k 
-	dh_installdirs
-
-	# Add here commands to install the package into debian/tmp
-	$(MAKE) install DESTDIR=$(CURDIR)/debian/tmp
-	$(RM) .libs/*.la
-
-# Build architecture-independent files here.
-binary-indep: build install
-# We have nothing to do by default.
-
-# Build architecture-dependent files here.
-binary-arch: build install
-	dh_testdir
-	dh_testroot
-	dh_installchangelogs ChangeLog
-	dh_installdocs
-	dh_installexamples
-	dh_install
-	dh_installinfo
-	dh_installman
-	dh_link
-	dh_strip
-	dh_compress
-	dh_fixperms
-#	dh_perl
-#	dh_python
-
-	@for f in $(LIBS); do \
-		echo "makeshlibs -p$$f" ; \
-		dh_makeshlibs -p$$f ; \
-	done
-
-	dh_installdeb
-	dh_shlibdeps
-	dh_gencontrol
-	dh_md5sums
-	dh_builddeb
-
-binary: binary-indep binary-arch
-.PHONY: build clean binary-indep binary-arch binary install 
-
-patch::
-unpatch::
\ No newline at end of file

Attachment: signature.asc
Description: Digital signature


Reply to: