Hi, I've made the following changes: - the orig.tar.gz is the same now as the upstream version - i removed the '*' chars from everywhere in manual and in sources too (only next release) - i removed the commented commands from debian/rules - i renamed REMARKS file to EXTRA_DIST (only next release) - i made sure that included generated files are removed (could you please check that? i removed these: autom4te.cache, config.guess, config.status, config.sub, config.log, stamp-h1, config.h, build-stamp) - i edited README everywhere to be within 80 chars width (only next release, i'm sill working on NEWS and ChangeLog) I have uploaded the aaphoto package to mentors. Andras On Sun, 21 Mar 2010 13:31:36 +0100 Joachim Reichel <joachim.reichel@gmx.de> wrote: > Hi Horvath, > > in addition to the items already mentioned by Chris: > > - the orig.tar.gz is different from > http://log69.com/downloads/aaphoto_sources_v0.36.tar.gz. The > orig.tar.gz has to be identical to the upstream one, unless you have > good reasons (which I could not spot). > > - please remove the "*" in the front of some option explanations in > the manpage > > - debian/rules: please remove the commented commands that do not apply > to your package > > I'm interested in sponsoring this package if you fix these issues (and > the ones mentioned by Chris). > > Since you are also the upstream author: > > - Please make sure in the next version not to include generated files, > e.g., config.status or autom4te.cache. This should also make the > package significantly smaller. Hint: "make dist" and "make distcheck" > are your friend. Use EXTRA_DIST for files like REMARKS. > > - NEWS, ChangeLog, and README would be much better readable if > formatted to a page width of 80 or less characters > > - The feature I miss most is maintaining the original jpeg compression > quality. > > Joachim >
Attachment:
signature.asc
Description: PGP signature