Re: RFS: qwit (updated package)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Carlos Galisteo schrieb:
> On Tue, Sep 29, 2009 at 6:28 PM, Patrick Matthäi <pmatthaei@debian.org> wrote:
>> Hello,
>
> Hello Patrick. Thanks for your help.
>
>> there are some issues:
>> 1) interdiff states much more changes as you described in your changelog
>> (e.g. debian/rules).
>
> There are big upstream changes, but debian dir doesn't change very much.
>
> Find attached a diff file comparing the new debian dir with the previous one
Hm right, interdiff blows up :o
diff is clear now against your changes.
>
> How do you find changes in debian/rules? This particular file is
> untouched. Interdiff seems to think that *everything* is new...I'm a
> little lost here.
>
>> 2) It is not a new upstream version, it is a new svn snapshot and please
>> describe the upstream issue in your changelog, like:
>> * New upstream svn snapshot.
>> - Fixes issue X, where it does not update bar.
>> * Next entry.
>
> You're right. With 'new version' I meant 'first package built from
> the future stable branch' :).
> I've rephrased and detailed changes in a new package already uploaded
> to mentors. [1]
Now it is fine.
>
>> 3):
>> make[1]: Entering directory `/tmp/buildd/qwit-1.0+svn255'
>> /usr/bin/uic-qt4 src/MainWindow.ui -o var/ui_MainWindow.h
>> make[1]: svnversion: Command not found
>> for every line, is this wanted?
>
> It replaces the 'revision' property with the svn 'head' revision
> number for each file.
>
> I guess this is not _needed_ but _wanted_ either by the upstream or
> by the IDE. Obviously, 'subversion' should be added to Build-depends
> in order to fix this errors (not done yet), but I don't find this is
> very elegant.
>
> The other option is to talk with upstream about "how much does he
> need it" and come to an agreement with him (he is quite nice and
> responsive).
Try it out :)
>
> Regards.
>
> [1] http://mentors.debian.net/debian/pool/main/q/qwit/qwit_1.0+svn255-1.dsc
>
>
Uploaded.
- --
/*
Mit freundlichem Gruß / With kind regards,
Patrick Matthäi
GNU/Linux Debian Developer
E-Mail: pmatthaei@debian.org
patrick@linux-dev.org
Comment:
Always if we think we are right,
we were maybe wrong.
*/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAkrDfHMACgkQ2XA5inpabMdIegCeIU5ZrOi1gPa/exzuSNvkYV2r
syAAn1Wk3WHLgfFmhocj5kXDLbV3qoMP
=j4F7
-----END PGP SIGNATURE-----
Reply to: