Re: RFS: kmfl-keyboards-mywin (updated package)
Here is a review of your package:
You could reduce the amount of changes needed in debian/rules in
future by using wildcards in debian/rules. Alternatively, since you
are upstream, why does the .kmn file need to have a version number in
it?
The upstream copyright years changed, but you did not change the ones
in debian/copyright.
You use an outdated Standards-Version, please read the upgrading
checklist document and make any needed changes.
The debian/changelog entry for 2.2.0-1 closes #456317, but that was
already closed by version 2.1.1-2.
Why do you install the .bmp and .png files twice?
Some complaints from lintian --info --display-info
--display-experimental --pedantic --show-overrides --checksums --color
auto
I: kmfl-keyboards-mywin source: debian-watch-file-is-missing
W: kmfl-keyboards-mywin source: out-of-date-standards-version 3.8.0
(current is 3.8.3)
P: kmfl-keyboards-mywin: copyright-refers-to-symlink-license
usr/share/common-licenses/GPL
I: kmfl-keyboards-mywin: copyright-with-old-dh-make-debian-copyright
P: kmfl-keyboards-mywin: no-upstream-changelog
PS: do you plan to package any of the other ThanLwinSoft software for Debian?
PPS: some Debian i18n links in case you want to do some translation
and are not yet working on that:
http://d-i.alioth.debian.org/doc/i18n/
http://wiki.debian.org/I18n
http://www.debian.org/international/
http://www.debian.org/doc/developers-reference/l10n.html#l10n-faqtr
http://lists.debian.org/debian-i18n/
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: