[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: iptotal (updated package, adopting)



Ignace Mouzannar wrote:
> Hi Barry,
> 
> Thank you for reviewing my package.
> 
> On Sun, Nov 15, 2009 at 23:57, Barry deFreese <bdefreese@debian.org> wrote:
>> Hi Ignace,
>>
>> Seems to be one issue (and one minor).
>>
>> bdefreese@bddebian3:~/debian/iptotal$ lintian -I
>> /home/bdefreese/pbuild-unstable/result/iptotal_0.3.3-9_i386.changes
<snip>

>> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/images/eth_year.png
> 
> I was unable to reproduce this on my machine. Nevertheless, I have
> edited the debian/rules file to deal with these files. It must be
> fixed now.
> 

Are you running lintian on your .changes file after building in pbuilder (or
cowbuilder, etc)?

>> I: iptotal: unused-override package-contains-empty-directory
>> usr/lib/iptotal/archive/
> 
> I intentionally had this folder created upon installation (adding a
> lintian override), as this is not done by iptotal(8) itself. Should I
> proceed differently?
> 

That's fine but the message seems to indicate that the dir isn't actually there.
 Is the dir really there?

>> Otherwise it looks fine to me.
>>
>> Thanks,
> 
> Thank you for your review.
> 
> I have just uploaded a new version on m.d.n [1]
> 
> Kind regards,
>  Ignace M
> 
> [1] The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/i/iptotal
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/i/iptotal/iptotal_0.3.3-9.dsc
> 

Barry


Reply to: