Re: RFS: iptotal (updated package, adopting)
Hi Barry,
Thank you for reviewing my package.
On Sun, Nov 15, 2009 at 23:57, Barry deFreese <bdefreese@debian.org> wrote:
> Hi Ignace,
>
> Seems to be one issue (and one minor).
>
> bdefreese@bddebian3:~/debian/iptotal$ lintian -I
> /home/bdefreese/pbuild-unstable/result/iptotal_0.3.3-9_i386.changes
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/15Dec2001.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/16Dec2001.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/17Dec2001.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/18Dec2001.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/archive/15Dec2001.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/archive/16Dec2001.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/archive/17Dec2001.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/archive/18Dec2001.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/eth_2hr.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/eth_day.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/eth_month.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/eth_week.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/eth_year.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/images/eth_2hr.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/images/eth_day.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/images/eth_month.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/images/eth_week.png
> W: iptotal: image-file-in-usr-lib usr/lib/iptotal/images/eth_year.png
I was unable to reproduce this on my machine. Nevertheless, I have
edited the debian/rules file to deal with these files. It must be
fixed now.
> I: iptotal: unused-override package-contains-empty-directory
> usr/lib/iptotal/archive/
I intentionally had this folder created upon installation (adding a
lintian override), as this is not done by iptotal(8) itself. Should I
proceed differently?
> Otherwise it looks fine to me.
>
> Thanks,
Thank you for your review.
I have just uploaded a new version on m.d.n [1]
Kind regards,
Ignace M
[1] The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/i/iptotal
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/i/iptotal/iptotal_0.3.3-9.dsc
Reply to: