Re: Re: RFS: stx-btree
Quoting "Ury Stankevich" <urykhy@gmail.com>:
Hello,
* your binary-indep should not depend on targets that try compile the test-
suites (speedtest, wxbtreedemo, testsuite), but should only install
architecture independent parts of the source package into the corresponding
-dev (headers files containing templates) and -doc (doxygen files) binary
packages.
* your binary-arch can compile the test-suites and eventually clean the
resulting object files
..
Also, at some later point you might decide to split a
separate wxbtreedemo binary package (arch:any) so it must be handled by
binary-arch anyway (debian policy 4.7).
yes, i make a package for wxbtreedemo (in binary-arch)
Okay, in that case it is recommended to provide support for DEB_BUILD_OPTIONS.
http://www.debian.org/doc/debian-policy/ch-source.html#s-debianrules-options
(having noopt and nostrip should be fine)
binary-indep now doesn't compile anything (can be run just after a configure)
Good.
* there are some more build-dependencies (wx, cppunit) you could
add related
to test-suites, though configure script handles these gracefully
if they are
not present, but you want to run the test-suite after all ;-).
yes, i made changes in rules to run testsuite in install-arch, or
maybe better to
run tests in build ?
Actually build target should depend on build-arch which handles the
building process.
* debian/copyright is incomplete - there are GPL-2'ed source files in
wxbtreedemo directory (licensecheck -r . from devscripts package
might be of
service). Also, /usr/share/common-licenses/LGPL is a symlink, you
want to use
LGPL-2.1 in your copyright file, same for GPL-2.
i make a notice about 2 parts of package, but i fail to find a sample,
can you help a bit
if my copyright file is wrong again?
It is now correct, though you could s/GPL/GPL-2/ for your debian packaging.
Even better, have a look at:
http://dep.debian.net/deps/dep5/
the rest of changes looks to be simple )
thanks for you help.
You are welcome.
P.S. no need to CC, I'm subscribed, though I might be slow with
replies occasionally.
Reply to: