[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libvigraimpex (updated package, fixes an RC bug)



* George Danchev <danchev@spnet.net>, 2009-10-12, 19:22:
http://mentors.debian.net/debian/pool/main/l/libvigraimpex/libvigraimpex_1.6.0+dfsg-1.dsc

* that one looks like a leftover or you really had anything `conditional' in
mind, but forgot to complete it?:

override_dh_auto_install:
   $(MAKE) install-exec install-includes prefix=$(CURDIR)/debian/tmp/usr; fi

It's a leftover. Awkwardly, it doesn't do any harm if /bin/sh is symlinked to
/bin/dash:

$ dash -c "echo foo; fi"; echo $?
foo
0

$ bash -c "echo foo; fi"; echo $?
bash: -c: line 0: syntax error near unexpected token `fi'
bash: -c: line 0: `echo foo; fi'
2

Anyways, fixed in VCS.

* resample-image-different-xy.diff could be eventually refreshed. Has it been
pushed upstream or at least tried to?

This patch was taken from the upstream VCS.

viff-typo.diff and docsrc-doxygen-any-version.diff hopefully could also be pushed upstream I guess.

I'll try to push them.

* I also saw that you have added Vcs-*, so I guess in order to save you some
upload-to-mentors hassle I can use debcheckout (since I'm not that much into
mercurial) to fetch your latest source package and pristine-tar to regenerate
orig.tar.gz you have prepared at your side, or we can use a simple get-orig-
source target to wget/curl the tarball if you prefer. So, let me know if that
worth the effort so we can arrange it as well.

VIGRA tarballs are huge and I'd love to avoid keeping them in VCS or pushing them to mentors.d.n. debcheckout + get-orig-source is fine for me.

--
Jakub Wilk


Reply to: