[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: jigzo (updated package) Fix bug #549515

Hi Jan,
First of all, thanks for show interest to jigzo, :)

On Sat, Oct 10, 2009 at 3:30 PM, Jan Hauke Rahm <jhr@debian.org> wrote:
Hi Elías,

On Thu, Oct 08, 2009 at 07:21:20PM -0500, Elías Alejandro wrote:
> I am looking for a sponsor for the new version 0.6.1-4
> of my package "jigzo".
> It builds these binary packages:
> jigzo      - Photo puzzle game for children
> jigzo-data - data of Photo puzzle game for children
> The package appears to be lintian clean.

That is true, although you could avoid the pedantic warning of lintian
about the symlink to GPL.

> The upload would fix these bugs: 549515

Right and your changes seem reasonable. What do not understand is your
usage of debhelper. You claim to have rewritten debian/rules in a recent
version but you didn't make use of debhelper 7. instead every single
command is written out, even dh_install appears multiple times for
different files. I'd like you to have a look at the man pages for
dh_install and dh. The changes don't *have* to be done but since I'm
pretty sure debian/rules could be as short as

   dh $@ --with quilt

it might make sense to rethink it. What do you say?
Please, Could you check it again? I've fixed the warning of lintian,
and modified rules.

As usual:
The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/j/jigzo
- Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/j/jigzo/jigzo_0.6.1-4.dsc


Elías Alejandro.

Version: GnuPG v1.4.10 (GNU/Linux)


Reply to: