[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: getstream (updated package)



> Hervé Rousseau wrote:
> > Dear mentors,
> >
> > I am looking for a sponsor for the new version 20081204-1
> > of my package "getstream".
> >
> > It builds these binary packages:
> > getstream  - DVB streaming application
> >
> > The package appears to be lintian clean.
> >
> > The package can be found on mentors.debian.net:
> > - URL: http://mentors.debian.net/debian/pool/main/g/getstream
> > - Source repository: deb-src http://mentors.debian.net/debian unstable
> > main contrib non-free
> > - dget
> > http://mentors.debian.net/debian/pool/main/g/getstream/getstream_20081204
> >-1.dsc
> >
> > I would be glad if someone uploaded this package for me.
> >
> > Kind regards
>
> Please remove the comments from debian/rules.

That is not a big deal ;-). This hopefully fixes a bug (LP: #365658) which is 
also present in the version found in sid, although never being reported, but I 
don't have a DVB card to verify that it actually fixes that bug. Did you 
checked that out?

There is also a very innocent memory leak you might want to fix:

--- libhttp.c.orig      2009-08-23 16:36:05.000000000 +0200
+++ libhttp.c   2009-08-23 16:39:43.000000000 +0200
@@ -556,11 +556,15 @@
        hs->sin.sin_addr.s_addr=INADDR_ANY;

        if (bind(hs->fd, (struct sockaddr *) &hs->sin,
-                               sizeof(struct sockaddr_in)))
+                               sizeof(struct sockaddr_in))) {
+               free(hs);
                return NULL;
+       }

-       if (listen(hs->fd, 3))
+       if (listen(hs->fd, 3)) {
+               free(hs);
                return NULL;
+       }

        flags=fcntl(hs->fd, F_GETFL);
        fcntl(hs->fd, F_GETFL, flags | O_NONBLOCK);


-- 
pub 4096R/0E4BD0AB 2003-03-18 <people.fccf.net/danchev/key pgp.mit.edu>

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: