[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: gforth (adopted & updated)



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Peter Pentchev schrieb:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 0.7.0+ds1-1
> of my package "gforth".  This is an adoption upload (ITA #540827)
> which pretty much overhauls the Debian packaging, fixes a long-standing
> manpage rendering problem, and fixes a bug regarding the proper
> compilation and installation of the Emacs Forth mode file.
> 
> Gforth used to build a single package, but with this version I'm
> splitting the shared data out:
> gforth        - GNU Forth Language Environment
> gforth-common - GNU Forth architecture-independent dictionaries
> 
> The package has been tested with lintian and pbuilder.
> 
> The upload would fix these bugs: 385399 (gforth.el), 540827 (ITA)
> 
> The package can be found on mentors.debian.net:
> http://mentors.debian.net/debian/pool/main/g/gforth/gforth_0.7.0+ds1-1.dsc
> 
> JFYI, here's my adoption changelog entry.  I'd be glad for any comments,
> since I do realize that a whole night of hacking instead of sleeping is
> liable to leave a loose end or three somewhere :)
> 

Hello,

on the first look it is fine, but I found a RC bug:

> gforth (0.7.0+ds1-1) unstable; urgency=low
> 
>   * New maintainer.  Closes: #540827
>   * Use quilt for patch management and add the debian/README.source file.
>   * Fix the build:
>     - specify an absolute prefix to "make install".
>     - remove a couple of files that "make distclean" seems to miss.
>   * Add the Homepage, Vcs-Svn, and Vcs-Browser control fields.
>   * Install the NEWS file as an upstream changelog.
>   * Deal with config.sub and config.guess properly - copy them from
>     the autotools-dev package before running "configure" and remove them
>     in the "clean" target.
>   * Keep the vmgen.1 manual page in the debian/ directory.
>   * Bump the debhelper compatibility level to 7:
>     - version the debhelper build dependency
>     - add ${misc:Depends} to the binary package
>     - leave removing of the *-stamp files to dh_clean
>     - use dh_prep instead of dh_clean -k
>     - shorten the rules file using the dh(1) helper and override targets
>     - disable debhelper's verbose mode
>   * Bump Standards-Version to 3.8.3:
>     - leave "install-info" to dpkg triggers and add the proper dependency
>   * Disable an i*86 "optimization" of passing the non-existing -m486
>     option to gcc.
>   * Break out /usr/share/gforth/ into a gforth-common package.

You are missing replaces and conflicts at your new gforth-common
package, upgrades / installations would fail if they install your
- -common package and the old gforth one.


>   * Make three example scripts executable.
>   * Repackage to remove the CVS directories.
>   * Fix the .TQ macro invocations in the groff.1 manual page so that
>     the short options are actually rendered!
>   * Add all the copyright holders to the copyright file and convert it
>     to the DEP 5 format.
>   * Properly compile and install gforth.el.  Closes: #385399.
> 
>  -- Peter Pentchev <roam@ringlet.net>  Sun, 23 Aug 2009 10:05:05 +0300
> 
> I would be glad if someone uploaded this package for me.
> 
> G'luck,
> Peter
> 


- --
/*
Mit freundlichem Gruß / With kind regards,
 Patrick Matthäi
 GNU/Linux Debian Developer

E-Mail: pmatthaei@debian.org
        patrick@linux-dev.org

Comment:
Always if we think we are right,
we were maybe wrong.
*/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEUEARECAAYFAkqQ8igACgkQ2XA5inpabMc6xwCbBY5hD3dhwn9IJfGLDbp95pBN
eqkAlR+Ip0pqtWPHDQfWmNohGOpTyA8=
=h+XM
-----END PGP SIGNATURE-----


Reply to: