On Sat, Aug 22, 2009 at 10:07:41AM +0200, Patrick Matth??i wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Peter Pentchev schrieb:
> > Dear mentors,
> >
> > I am looking for a sponsor for version 0.5-18 of the package "donkey"
> > which I am trying to adopt (ITA #541053). It is a simple S/Key
> > (one time password) generator which could come quite useful to
> > people who still care :)
> >
> > * Package name : donkey
> > Version : 0.5-18
> > Upstream Author : Kazuhiko Yamamoto <kazu@is.aist-nara.ac.jp>
> > * License : GPL-2/GPL-2+
> > Language : C
> > Section : net
> >
> > It builds a single binary packages:
> > donkey - One Time Password calculator
> >
> > The package has been tested with lintian and pbuilder.
> >
> > The upload would fix these bugs: 414341 (FTBFS), 541053 (ITA)
> >
> > The package can be found on mentors.debian.net:
> > dget -x http://mentors.debian.net/debian/pool/main/d/donkey/donkey_0.5-18.dsc
> >
> > JFYI, here's my adoption changelog entry:
>
>
> Hello,
Hi, and thanks for the review! I've uploaded a new package with
the same version at the above URL, which fixes some of your issues and
also reformats the long description field, as suggested by Kartik Mistry
in private mail. Responses inline...
> > donkey (0.5-18) unstable; urgency=low
> >
> > * New maintainer. Closes: #541053
> > * Fix a FTBFS on GNU/kFreeBSD. Closes: #414341
> > * Properly clean up the object directory as also suggested by
> > Cyril Brulebois in #414341 :)
>
> I realy do not like smileys in changelogs, please remove it.
Point taken. I was kinda doubtful about it myself. Smiley removed.
> > * Add the Vcs-Svn and Vcs-Browser control fields.
> > * Add a watch file.
> > * Escape several minus signs in the manual page.
> > * Remove the dot at the end of the short description.
> > * Specify a debhelper compatibility version of 7:
> > - create the debian/compat file
> > - install into debian/donkey instead of debian/tmp
> > - version the debhelper build dependency
> > - add ${misc:Depends} to the binary package
> > - minimize the rules file using override targets
> > * Bump Standards-Version from 3.2.1 to 3.8.3 with no changes :)
>
> Same and I do not believe that you can switch from 3.2 to 3.8 without
> changes, what is e.g. with donkey-0.5/debian/README.source
Again, smiley removed. As to the standards version update, well, for
a very simple package that has nothing to do with X, is not a webserver,
and uses debhelper, it is, indeed, possible. I was surprised, too,
but it's true.
The changelog entries were written in the order of doing the work.
The Standards Version update came *before* the C compiler warnings fix,
and the quilt usage (thus README.source) is only there because of
the warnings fix. So, at the time I bumped Standards-Version, there
was no README.source file.
> > * Add all copyright holders to the copyright file and convert it to
> > the DEP 5 format.
> > * Silence a couple of compiler warnings with a quilt patch and
> > a README.source file to note the use of quilt.
> > * Use the build hardening wrapper.
>
> I do not think that this is a good idea, the package is highly experimental.
> You may manual add/override compiler flags in debian/rules.
True. My recent problems with confget (see #526961), and yours and
George Danchev's doubts about the hardening wrapper have just managed
to cause me to change my own policy on using it :) In the new package,
the hardening wrapper is enabled if "hardening" is in DEB_BUILD_OPTIONS.
> > -- Peter Pentchev <roam@ringlet.net> Fri, 21 Aug 2009 16:14:13 +0300
> >
> > I would be glad if someone uploaded this package for me.
>
> Last note:
>
> Your package lacks a homepage control field.
Yes, I know; there simply isn't one. It seems that upstream has been,
to put it mildly, not very active for the past couple of years.
Still, since donkey is a useful and simple piece of software, I fully
intend to take over upstream duties, too, if the need should arise;
if that happens, there will be an upstream homepage.
G'luck,
Peter
--
Peter Pentchev roam@ringlet.net roam@space.bg roam@FreeBSD.org
PGP key: http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553
"yields falsehood, when appended to its quotation." yields falsehood, when appended to its quotation.
Attachment:
pgpwyaZq0nrvq.pgp
Description: PGP signature