[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: roxterm (now 1.15.2-1)



> On Mon, 6 Jul 2009 13:25:04 +0200
>
> Sebastian Harl <sh@tokkee.org> wrote:
> > On Sun, Jul 05, 2009 at 01:59:17PM +0100, Tony Houghton wrote:
> > > Before I try uploading it again, it occurred to me that as 1.15.1-1
> > > hasn't been released, should I remove its entry from the changelog and
> > > add its changes to the section for 1.15.2-1?
> >
> > Imho, that's mostly up to your personal preferences. Some care should be
> > taken if you've closed bugs in older, unreleased changelog entries - the
> > entry should be included in .changes then to have those bugs closed
> > automatically in the BTS (see dpkg-buildpackage's -v option). Besides
> > that there is not much difference (imho), even though I prefer to have
> > only one changelog entry for each upload.
>
> I chose to merge the changelog. I've uploaded 1.15.2-1 again and this
> time it's showing up, so I'd be grateful for the attention of potential
> sponsors.

Sure, fixing bugs is always welcome, so package reviewed and uploaded. 
Everything looks fine, except that `move-all-then-remove-some' installation 
method [1] (which could be hazardous sometimes) could be avoided by using 
dh_install(1) next time.

[1]    $(MAKE) DESTDIR=$(CURDIR)/debian/roxterm install
        cp -f $(CURDIR)/debian/roxterm.xpm 
$(CURDIR)/debian/roxterm/usr/share/pixmaps/
        $(RM) $(CURDIR)/debian/roxterm/usr/share/doc/roxterm/COPYING
        $(RM) $(CURDIR)/debian/roxterm/usr/share/doc/roxterm/AUTHORS
        $(RM) $(CURDIR)/debian/roxterm/usr/share/doc/roxterm/README

Thanks for taking care of these bugs.

-- 
pub 4096R/0E4BD0AB 2003-03-18 <people.fccf.net/danchev/key pgp.mit.edu>

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: