[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: copher 0.2.0-1 (danchev)

2009/7/4 George Danchev <danchev@spnet.net>:

> Unfortunately, I'll be far away from my gpg key until Sunday night (UTC) and
> I would appreciate if another sponsor could take a look and upload before I
> get back...

Uploaded. I hope you both don't mind, but I took the liberty of
switching the urgency to medium instead of low due to the RC bug.

Some things that may need looking at:

In upstream's Makefile they use /usr as the default prefix. For stuff
installed from source they should be using /usr/local since /usr is
the domain of the package manager only. Please report this upstream.

The upstream Makefile doesn't support the DESTDIR variable, the
install lines should look like this:

	install -v -m755 copher.pl $(DESTDIR)$(PREFIX)/bin/copher
	install -v -m644 copher.1 $(DESTDIR)$(PREFIX)/share/man/man1/copher.1

You might want to consider installing THANKS and README.rubyforge,
which were added in this version.

Shouldn't you depend on perl?

Is it really appropriate to put the short git commit hashes in debian/changelog?

Two lintian complaints:

I: copher: copyright-with-old-dh-make-debian-copyright
I: copher: extended-description-is-probably-too-short

Upstream seems to have forgotten to announce 0.2.0 on freshmeat.net,
you might want to ping them or do the update yourself (since freshmeat
now allows editing by anyone).

You might want to suggest that upstream add a ideatorrent request for
sourceforge to add an API, that way the sf.net handling would be much
less brittle:


You might want to make a screenshot for screenshots.debian.net or
write an article about copher for debaday.debian.net.



Reply to: