On Mon, 1 Jun 2009 11:44:57 +0200, Michal Čihař wrote:
> Hi
Hello Michal,
thanks for the review.
> Dne Sat, 30 May 2009 18:41:12 +0200
> David Paleino <d.paleino@gmail.com> napsal(a):
>
> > The package is lintian clean (just debian-watch-file-is-missing, but since I
> > don't have a homepage yet...)
> >
> > The package can be found on Alioth:
> >
> > http://alioth.debian.org/~hanska-guest/apt/unstable/claws-mail-debian-spam-plugin_0.0.1-1.dsc
>
> Few comments:
>
> - please remove commented out parts of debian/rules
I suppose the one in the clean target, done.
> - debian/dirs and debian/install seem to be extra (make install works,
> so why you install things manually?)
Because only the .so should be installed.
I fixed this
> - debian/copyright misses link to format specification
Yes, that slipped off while writing it, thank you. (I really should've checked
it before RFSing...)
> - lintian slightly complains, but as you have no homepage, it is not
> fixable:
> I: claws-mail-debian-spam-plugin source: debian-watch-file-is-missing
> P: claws-mail-debian-spam-plugin: no-homepage-field
Will fix those as soon as I publish the code somewhere :)
> P: claws-mail-debian-spam-plugin: copyright-refers-to-symlink-license
> usr/share/common-licenses/GPL
This lintian warning is wrong here: :)
X-Comment: on Debian systems, the complete text of the GNU General
Public License version 3 can be found in `/usr/share/common-licenses/GPL-3',
while the latest version can be found in `/usr/share/common-licenses/GPL'.
That whole paragraph is right. Since the code is GPL-3+, I'm both pointing to
the minimum version (GPL-3) and the latest ("+", GPL) -- they just happen to be
the same at this time.
> For second (pedantic) warning, why did you use X-Comment field?
To point to copies of licenses in /usr/share/common-licenses/, without
violating the RFC.
> Neither DEP-5 nor the wiki page seems to mention this field.
DEP-5:
Extra fields.
Extra fields can be added to any section. Their name starts by X-.
Also in RFC822:
4.7.5. USER-DEFINED-FIELD
Individual users of network mail are free to define and
use additional header fields. Such fields must have names
which are not already used in the current specification or in
any definitions of extension-fields, and the overall syntax of
these user-defined-fields must conform to this specification's
rules for delimiting and folding fields. Due to the
extension-field publishing process, the name of a user-
defined-field may be pre-empted
Note: The prefatory string "X-" will never be used in the
names of Extension-fields. This provides user-defined
fields with a protected set of names.
> Once you will address these, I can upload it.
.dsc available at the same url as before:
http://alioth.debian.org/~hanska-guest/apt/unstable/claws-mail-debian-spam-plugin_0.0.1-1.dsc
Thank you,
David
--
. ''`. Debian maintainer | http://wiki.debian.org/DavidPaleino
: :' : Linuxer #334216 --|-- http://www.hanskalabs.net/
`. `'` GPG: 1392B174 ----|---- http://snipr.com/qa_page
`- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
Attachment:
signature.asc
Description: PGP signature