[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: claws-mail-debian-spam-plugin



Hi

Dne Sat, 30 May 2009 18:41:12 +0200
David Paleino <d.paleino@gmail.com> napsal(a):

> The package is lintian clean (just debian-watch-file-is-missing, but since I
> don't have a homepage yet...)
> 
> The package can be found on Alioth:
> 
>   http://alioth.debian.org/~hanska-guest/apt/unstable/claws-mail-debian-spam-plugin_0.0.1-1.dsc

Few comments:

- please remove commented out parts of debian/rules
- debian/dirs and debian/install seem to be extra (make install works,
  so why you install things manually?)
- debian/copyright misses link to format specification
- lintian slightly complains, but as you have no homepage, it is not
  fixable:
I: claws-mail-debian-spam-plugin source: debian-watch-file-is-missing 
P: claws-mail-debian-spam-plugin: copyright-refers-to-symlink-license usr/share/common-licenses/GPL
P: claws-mail-debian-spam-plugin: no-homepage-field

For second (pedantic) warning, why did you use X-Comment field? 
Neither DEP-5 nor the wiki page seems to mention this field.

Once you will address these, I can upload it.

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

Attachment: signature.asc
Description: PGP signature


Reply to: