Re: RFS: valkyrie
Hello,
On Wed, May 6, 2009 at 20:16, Hai Zaar <haizaar@haizaar.com> wrote:
> On Tue, May 5, 2009 at 5:59 AM, LI Daobing <lidaobing@debian.org> wrote:
>>> The package can be found on mentors.debian.net:
>>> - URL: http://mentors.debian.net/debian/pool/main/v/valkyrie
>>> - Source repository: deb-src http://mentors.debian.net/debian unstable
>>> main contrib non-free
>>> - dget http://mentors.debian.net/debian/pool/main/v/valkyrie/valkyrie_1.4.0-1.dsc
>>>
>>> I would be glad if someone uploaded this package for me.
>>>
>>
>> comments:
>>
>> 1. lintian warning:
>> W: valkyrie source: timewarp-standards-version (2008-05-02 <
>> 2008-06-04), you forget to update your changelog's timestamp(you can
>> use dch to update this timestamp).
> Fixed.
>> you also need change standards version to 3.8.1
> Fixed.
>
>>
>> 2. no watch file and no get-orig-source target in debian/rules
> I've created watch file. About get-orig-source - can you provide any
> reference what it is exactly and why do we need it? It the first time
> I hear about it, and some sources (like this:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=494141) state that
> its obsolete?
>>
>> 3. valkyrie 1.4.0 only works for valgrind >= 3.4, please change the
>> description and set version constrain in recommends.
>> (from: http://www.valgrind.org/downloads/)
> Fixed.
>
still one more issue: the copyright file
the debian policy[1] said you should provide the verbatim copy of the
copyright file, for GPL-2 you should keep following paragraphs:
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License along
with this program; if not, write to the Free Software Foundation, Inc.,
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
there is a proposed copyright format in [2], you also can use that format.
[1] http://www.debian.org/doc/debian-policy/ch-docs.html , section 12.5
[2] http://dep.debian.net/deps/dep5/
--
Best Regards
LI Daobing
Reply to: