[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: sigx (second attempt)



On Tuesday 05 May 2009 20:43:08 Patrick Matthäi wrote:
> Chow Loong Jin schrieb:
> > Dear mentors,
> >
> > I am looking for a sponsor for my package "sigx".
> >
> > * Package name    : sigx
> >   Version         : 2.0.2-1
> >   Upstream Author : [fill in name and email of upstream]
> > * URL             : [fill in URL of upstreams web site]
> > * License         : [fill in]
> >   Section         : devel
>
> Next time please fill them in.
>
> > The package appears to be lintian clean.
>
> No:
>
> P: libsigx-2.0-doc: copyright-refers-to-symlink-license
> usr/share/common-licenses/GPL
> P: libsigx-2.0-dev: copyright-refers-to-symlink-license
> usr/share/common-licenses/GPL
> I: libsigx-2.0-2: no-symbols-control-file usr/lib/libsigx-2.0.so.2.0.1
> P: libsigx-2.0-2: copyright-refers-to-symlink-license
> usr/share/common-licenses/GPL
>
> > The upload would fix these bugs: 492215
> >
> > The package can be found on mentors.debian.net:
> > - URL: http://mentors.debian.net/debian/pool/main/s/sigx
> > - Source repository: deb-src http://mentors.debian.net/debian unstable
> > main contrib non-free - dget
> > http://mentors.debian.net/debian/pool/main/s/sigx/sigx_2.0.2-1.dsc -
> > gitweb: http://git.debian.org/?p=collab-maint/sigx.git
> > - git clone git://git.debian.org/git/collab-maint/sigx.git
> > I would be glad if someone uploaded this package for me.
>
> The rest seems clear to me, could you please fix the lintian messages,
> then I am willed to upload it. :)

Looks good to me too. A couple of comments though:

I'm a little bit concerned is that build-depending on  versioned boost -dev 
package (libboost1.35-dev) without exact justification is just adding to the 
burden when boost migrations occur or boost 1.35 packages gets dropped. As I 
can see the sigx code only uses a stable core of boost like
std::tr1::shared_ptr (<tr1/memory>). These tr1 facilities have been introduced 
in version 1.34.0. Therefor build-depending on libboost-dev (which is 
currently 1.34.1) is safe enough and would avoid the burden to update the 
package when 1.35 gets dropped.

-- 
pub 4096R/0E4BD0AB 2003-03-18 <people.fccf.net/danchev/key pgp.mit.edu>


Reply to: