[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: blimp

On Sat, Jan 24, 2009 at 10:57:53PM +0100, Knut Arild Erstad wrote:
> Dear mentors,
> I am looking for a sponsor for my package "blimp".

IANADD, but some general comments until a sponsor comes along.

You don't seem to have an Intent to Package filed. ITPs prevent code
duplication, unneccessary packages and other problems. It should be
closed in your changelog. [1]

debian/changelog: You can squash your entry for 1.0-1, because it was
never in the archive. Close your ITP as above.

debian/copyright: you should acknowlege the copyright of the additional
resources you include (jiu). On a related note, you should also check
whether jiu is already in the archive and depend on it, instead of
including it.

The short description isn't very good; on seeing that, what makes me
want to install it?

Seems you build blimp, dcraw and some java classes all in the same
package. IMO, you should split these so that either blimp becomes a multiple
binary package, building seperate binary packages and having appropriate
dependencies, or dcraw, for example, might be useful to other maintainers
and should be a completely new source package. Later, when you or
another maintainer wants to use these components for something else, it
is trivial.

Finally you should get rid of cruft and comments in debian/rules, to
make it easy to read. You could also investigate debhelper 7, which
makes this a lot easier.

[1] http://debian.org/doc/developers-reference/pkgs.html#newpackage

Hope that helps,

Jonathan Wiltshire

PGP/GPG: 0xDB800B52 / 4216 F01F DCA9 21AC F3D3  A903 CA6B EA3E DB80 0B52

Attachment: signature.asc
Description: Digital signature

Reply to: