Re: RFS: battery-stats (updated package)
On Sat, Jan 17, 2009 at 18:31, Sandro Tosi <morph@debian.org> wrote:
> On Sat, Jan 17, 2009 at 18:26, Antonio Radici <antonio@dyne.org> wrote:
>> Dear mentors,
>>
>> I am looking for a sponsor for the new version 0.3.3-3
>> of my package "battery-stats".
>
> Checking
debian/rules:
- don't write the patch/unpatch targets explicitly but "include
/usr/share/dpatch/dpatch.make"
debian/patches/desc
- what's this file?
debian/control
- do you need a bump in gnuplot versioned depends because "gnuplot is
using a new syntax so it should be reflected in the command the
package uses" ?
- add ${misc:Depends} to Depends
- remove the extra (empty) line at the end of this file
- I think logrotate should be elected to Depends: what will happen if
it's missing and at install time the package wants to install its
logrotate rule file?
- I'd describe the bin programs in the packaeg in the long description
(battery-graph in the paragraph about the graph, and battery-log in
another (new) paragraph).
debian/copyright
- I'd separate clearly the copyright and license section with a proper header
- I'd use GPL-2 file for common-license reference (and hence GPLv2 in
the same paragraph)
debian/README.source
- missing, but policy 3.8.0 "should" its presence in case of patch system
debian/README
- I'd refresh the info in this file a bit
debian/watch
- what about adding one? if it makes sense given the situation; are
you even adopting it upstream?
There is a small issue when running battery-graph and the log file is empty:
$ battery-graph
gnuplot> plot "-" using ($1 - 946681200):2 smooth unique axis x1y1
title "Battery %" with lines linewidth 3
^
line 0: warning: Skipping data file with no valid points
There are some lintian message to fix:
$ lintian -I ../pbuilder/result/battery-stats_0.3.3-3_amd64.changes
I: battery-stats source: debian-watch-file-is-missing
W: battery-stats source: dh-clean-k-is-deprecated
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:86
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:89
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:93
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:96
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:99
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:103
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:106
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:110
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:113
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:116
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz 3 more occurrences not shown
$ lintian -V
Lintian v2.1.5
They are all pretty simple to fix (the show stopper is dpatch.make
missing) and otherwise the package works fine (at least for the short
time it's running here). Please get back to me once you've uploaded
the package again (no revision bump) to mentors.
Regards,
--
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
Reply to: