[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: nmapsi4



Sandro Tosi ha scritto:
> On Sun, Oct 26, 2008 at 23:07, Giuseppe Iuculano <giuseppe@iuculano.it> wrote:
>> Sandro Tosi ha scritto:
>>> Why is "Section: web"? if you want to mimik nmap, its section is net.
> 
> what about this?

Fixed

> But description still contains:
> 
> - "NmapSI4 s a"
> - "design goals" while I think it's a singular goal, that is "to
> provide a complete nmap interface for Users"
> - "Users" that needs to be un-capitalized
> 
> and even Network should be uncapitalized

Argh, now it should be really fixed :)


> 
>>> Since you claim "Standards-Version: 3.8.0", you need to ship
>>> debian/README.source simply with a simple text like:
>> Added
> 
> Good, but I don't this the "-- <name> <email> <date>" line belongs to
> this file, so I'd remove it
>

Ok, removed.


>>> Please merge "rm -f *-stamp" into dh_clean (they do the same job).
>> Fixed
> 
> Ehm, not this :) you simply removed the "rm" line...

Yes, because dh_clean (debhelper v7) runs a "rm -f *-stamp", from man page:
It also removes common files that should not appear in a debian diff:
         #*# *~ DEADJOE *.orig *.rej *.SUMS TAGS .deps/* *.P *-stamp



Uploaded again.

Giuseppe.

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: