[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

cracklib2 bashism in update-cracklib fixed



Hello release team, hello mentors,

the Ubuntu folks discovered a bug [1] in cracklib-runtime that turned
out to be caused by a bashism in its update-cracklib script. Steve
Langasek fixed the issue in the Ubuntu package and forwarded me a link
to the debdiff [2].

Unfortunately a new upstream version of cracklib2 has been created and
was uploaded to unstable recently, so I cannot simply go the way
through unstable. I don't want to introduce the new upstream release
in Lenny at this late point of the release cycle and you surely do not
want it too.

I prepared an upload to testing-proposed-updates that includes only
the fix for the bug mentioned above and the fix for the
cracklib-runtime's postinst "maintainer-script-ignores-error" fix that
I made in 2.8.13-1. I'm no DD so I need a sponsor to upload the
package. I put the package on mentors.debian.net [3]. The debdiff is
attached to this mail.

Will the package reach Lenny this way? If not, could anybody please
unblock it when it's uploaded?


Regards
Jan Dittberner

[1] https://bugs.launchpad.net/bugs/278743
[2] http://launchpadlibrarian.net/18591357/cracklib2-278743.debdiff
[3] http://mentors.debian.net/debian/pool/main/c/cracklib2/cracklib2_2.8.12-8lenny1.dsc
diff -u cracklib2-2.8.12/debian/changelog cracklib2-2.8.12/debian/changelog
--- cracklib2-2.8.12/debian/changelog
+++ cracklib2-2.8.12/debian/changelog
@@ -1,3 +1,17 @@
+cracklib2 (2.8.12-8lenny1) testing-proposed-updates; urgency=low
+
+  [ Steve Langasek ]
+  * debian/update-cracklib: don't rely on [ -nt ] to return true when
+    the second file is non-existent, since this fails under dash.
+    LP: #278743.
+
+  [ Jan Dittberner ]
+  * integrate Ubuntu bugfix
+  * use set -e in debian/cracklib-runtime.preinst to fix lintian warning
+    maintainer-script-ignores-errors
+
+ -- Jan Dittberner <jan@dittberner.info>  Thu, 16 Oct 2008 21:04:24 +0200
+
 cracklib2 (2.8.12-8) unstable; urgency=low
 
   * provide a python-crack wrapper to mimic the behavior of the python-
diff -u cracklib2-2.8.12/debian/update-cracklib cracklib2-2.8.12/debian/update-cracklib
--- cracklib2-2.8.12/debian/update-cracklib
+++ cracklib2-2.8.12/debian/update-cracklib
@@ -24,7 +24,8 @@
 then
     for i in ${cracklib_dictpath_src}
     do
-        if [ "$i" -nt "${cracklib_dictpath}.pwd" ]
+        if ! [ -e "${cracklib_dictpath}.pwd" ] \
+	   || [ "$i" -nt "${cracklib_dictpath}.pwd" ]
         then
             /usr/sbin/cracklib-format ${cracklib_dictpath_src} | \
             /usr/sbin/cracklib-packer
diff -u cracklib2-2.8.12/debian/cracklib-runtime.preinst cracklib2-2.8.12/debian/cracklib-runtime.preinst
--- cracklib2-2.8.12/debian/cracklib-runtime.preinst
+++ cracklib2-2.8.12/debian/cracklib-runtime.preinst
@@ -1,5 +1,7 @@
 #!/bin/sh
 
+set -e
+
 case "$1" in
 install|upgrade)
     # /etc/cron.daily/cracklib -> cracklib-runtime transition

Attachment: signature.asc
Description: Digital signature


Reply to: