[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: lyricue



> Dear mentors,
>
> I am looking for a sponsor for my package "lyricue".
>

Hi, I noticed some things are being done manually in your debian/rules
that could probably be automated.  You carefully define the checkdir
macro and the checkroot target.  Is there any reason you aren't using
dh_testdir and dh_testroot, respectively?  Also, in the clean target,
dh_clean removes the following in compat 7 mode (I'm not sure about
compat 5):

#*# *~ DEADJOE *.orig *.rej *.SUMS TAGS .deps/* *.P *-stamp

That would remove the need to use a complicated find command.
Finally, any reason you are using a build: target with a touch build
at the end?  Most of the time packages I see have build: listed as
phony and then call build-stamp, which will touch itself.  These are
of course minor issues with the package.

Cheers,
Daniel Moerner <dmoerner@gmail.com>


Reply to: