Re: ITR: dbishell - QA upload
Hi Neil,
Thanks for the check!
On Wed, Aug 20, 2008 at 21:22, Neil Williams <codehelp@debian.org> wrote:
> Sandro, just a comment on dbishell 0.8.9-8 on mentors:
>
> The dbishell.new file created by
> debian/patches/000-previous-changes.patch appears to not be a patch at
> all. It is a temporary file that is neither packaged nor included in
> the .orig.tar.gz. It would be better to simply clean this file so that
> it does not show up in the .diff.gz (AFAICT the only reason for this
> file to show up in the lintian check.)
>
> I've done a test build after adding '$(RM) dbishell.new' to the clean
> rule in debian/rules and I didn't see any particular problems.
> Naturally, the patch needs to be cleaned up too.
ouh, sorry, I completely passed over it without noticing; I've just
re-uploaded the package
> Please make a 0.8.9-9 upload to mentors with the fixed patch and clean
> rule and I'll be OK to upload it.
As a personal feeling, I'd rather keep all those changes in the -8
revision, so I re-uploaded version 0.8.9-8; I hope you don't mind
about it.
Thanks in advance,
Sandro
--
Sandro Tosi (aka morph, Morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
Reply to: