[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: adtool (adoption)



On Sat, Dec 27, 2008 at 07:19:08PM +0100, Cyril Brulebois wrote:
> So, here it goes:
>  - there were some changes to upstream sources in the previous revision,
>    they went away but you're not mentioning it anywhere. Did you lost
>    them or did you trash them on purpose?
> | $ lsdiff -z ../adtool_1.3-1.diff.gz|grep -v /debian/|grep -v config
> | adtool-1.3/src/tools/adtool.c
> | adtool-1.3/src/etc/adtool.cfg.dist
> | adtool-1.3/src/lib/active_directory.c
>  - config.{guess,sub} are no longer updated during the build, I suggest
>    you copy them from the autotools-dev package, before the build, and
>    trash them in the clean target. Note that I'm not familiar with dh 7
>    yet, but maybe there's a nice way to do that.
>  - debian/dirs is only needed when the build system doesn't create those
>    directories, and that's almost never needed when autotools are used.

Ok, I'll address those now - would you like a version bump?

>  - not directly related to your packaging, it looks like CSS are missing
>    on your gitweb.

It's the stock debian package, so I'll look into that when I have time
:-)

Cheers



-- 
Jonathan Wiltshire

PGP/GPG: 0xDB800B52 / 4216 F01F DCA9 21AC F3D3  A903 CA6B EA3E DB80 0B52
Sending of encrypted mail is encouraged

Attachment: signature.asc
Description: Digital signature


Reply to: