Cyril Brulebois <kibi@debian.org> (27/12/2008):
> I'm willing to take a look, I'll get back to you soonish.
So, here it goes:
- there were some changes to upstream sources in the previous revision,
they went away but you're not mentioning it anywhere. Did you lost
them or did you trash them on purpose?
| $ lsdiff -z ../adtool_1.3-1.diff.gz|grep -v /debian/|grep -v config
| adtool-1.3/src/tools/adtool.c
| adtool-1.3/src/etc/adtool.cfg.dist
| adtool-1.3/src/lib/active_directory.c
- config.{guess,sub} are no longer updated during the build, I suggest
you copy them from the autotools-dev package, before the build, and
trash them in the clean target. Note that I'm not familiar with dh 7
yet, but maybe there's a nice way to do that.
- debian/dirs is only needed when the build system doesn't create those
directories, and that's almost never needed when autotools are used.
- not directly related to your packaging, it looks like CSS are missing
on your gitweb.
I'm quite happy with the other modifications.
Mraw,
KiBi.
Attachment:
signature.asc
Description: Digital signature