Re: Bug#247225: RFS: postfixadmin (2nd try)
Hi Paul,
thanks for your review!
Am Sonntag, den 02.11.2008, 17:43 +0900 schrieb Paul Wise:
> A review of your source package:
>
> Please send your changes upstream if you haven't already.
my small changes in backup.php are ported from upstream [1]
> The cp calls can be moved into debian/postfixadmin.install.
thanks for the hint, implemented.
> Some of the postinst might be replaced by wwwconfig-common and you
> might want to extend wwwconfig-common to support stuff it doesn't yet.
>
> #448682 is fixed, do you need to make an changes as a result?
Just closed bug #237292 in this context.
> Would it be possible to make dbconfig-common do the stuff listed in
> DOCUMENTS/SECURITY.txt? If not, please file a bug about it.
There is already such an reported bug: #400567.
> Standards-Version does not need the final .1 since only typos and
> minor changes occur in policy 3.8.0.X
adjusted.
> I don't know enough about debconf or web stuff to review the rest of
> the package.
I would be glad if someone could review that parts of my package!
I've uploaded a new version on mentors.debian.net
- URL: http://mentors.debian.net/debian/pool/main/p/postfixadmin
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget
http://mentors.debian.net/debian/pool/main/p/postfixadmin/postfixadmin_2.2.1.1-1.dsc
Thanks a lot,
Norman
[1]
http://sourceforge.net/forum/forum.php?thread_id=2387333&forum_id=676076
Reply to: