Re: evolution-remove-attachments package review
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi, Paul
Thanks for feedback.
Let me reply your questions inline.
Paul Wise wrote:
> Hi Rex,
>
> Just now I was looking for a way to remove attachments in evolution.
> While searching I found your plugin on mentors.debian.net. Since I'd
> like to use it (and therefore upload it to Debian), here is a review:
>
> Firstly it didn't actually work as expected. I attached your .dsc file
> to this message in my drafts folder, clicked the menu item, the message
> was deleted and a new message created, with the attachment still
> attached, but changed into a text file saying that the attachment has
> been removed. I expected that the attachment would actually be removed
> instead of made smaller and changed to text.
Well, the behavior is designed for purpose. I have many business
emails with large attachments, and I like to keep the emails for record
without the attachments. So, the plugin would not actually delete it but
replace a messages recorded that was a attachment. What I can do is to
put one more menu item as "purge attachments"
> A wishlist item: I'd like to be able to delete specific attachments,
> some messages can have more than one attachment but I don't want to
> delete all of them.
The whishlist item could be done, I suppose. I will look into it.
> I think it would be great if your plugin could be merged into upstream
> evolution for evolution 2.26 so everyone has it. I'll be happy to upload
> it to Debian in the meantime though.
Yes, it would be great. I submited a bug report[1] on gnome.org. I
also talked to Sankar P <psankar at novell dot com> on #evolution irc
channel, and psankar told me if the code need to get into svn, I need to
reassign the copyright to Novel. Which stop me to have the code in
upstream's svn repository. (even though I found not reason to keep the
copyright)
> The packaging seems specific to evolution 2.22 (version numbers in
> paths, conflicts against other versions), I think it would be good to
> future-proof it since evolution 2.24 has been released and hopefully
> will be in experimental soon (#). If that isn't possible, your
> build-dependencies will need to be tightened to require evo 2.22.
I will test it when 2.24 is available in experimental.
> You don't specify which version of the GPL that the Debian packaging is
> licensed under.
>
> You should use the full "This program is free software; you can
> redistribute it" blurb in the upstream source code, not just in
> debian/copyright.
You are right, I like to have the source code licensed under GPLv2, I
should mention it in the tarball.
> There is no homepage in debian/control and there is a related valid
> lintian -I warning:
>
> I: evolution-remove-attachments source: debian-watch-file-is-missing
Since it's a little plugin, I did not set up a home page for it.
Should I get it? :-)
1. http://bugzilla.gnome.org/show_bug.cgi?id=534453
regards
- -Rex
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkj0HKwACgkQOl4Wbdx2/rlMnQCeN8oCpv3eia7M2HARoZVRDzvJ
JcsAn2vsXZvjUWpYxyags7vq4w/54V8M
=CnUA
-----END PGP SIGNATURE-----
Reply to: