Re: RFS: arping (updated package)
On Sat, 20 Sep 2008 13:03:16 +0200, "Sandro Tosi" <matrixhasu@gmail.com>
wrote:
> * rules:
>
> ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
> INSTALL_FLAGS += -s
> endif
>
> - am I wrong, or this add "-s" to install (that will strip debug
> symbols & co) when DEB_BUILD_OPTIONS contains "nostrip"? if so, then
> it's the opposite of what you want :) [it might be un-used, hence
> remove it]
It's the opposite: findstring returns the match if any, and an empty string
if no match is found, so the "ifeq" test is checking whether DEB_BUILD_OPTIONS
does not contain "nostrip"... To check whether DEB_BUILD_OPTIONS does contain
"nostrip", the test would be
ifeq (nostrip,$(findstring nostring,$(DEB_BUILD_OPTIONS)))
But that's not much use since we're trying to determine the opposite!
In summary, the code quoted above is correct.
Regards,
Stephen
Reply to: