On Mon, Sep 01, 2008 at 07:33:44PM -0500, Raphael Geissert wrote:
>
> Makefile:
> This file is useless, you don't need it, you should drop it.
Removed, all the logic is moved to debian/rules
> debian/watch:
> > http://qa.debian.org/watch/sf.php/copher copher-(.*).tar.gz debian
> Did you know that the first part can be written as http://sf.net/copher ?
I get a 404. I was under the impression that the URL I have used was
required to allow for SF's load-balancing redirections.
> Also note that the unquoted dots after the closing parenthesis is actually
> interpreted as part of the regex and could actually match anything?
Fixed.
> debian/control:
> > Priority: extra
> why?
http://www.debian.org/doc/FAQ/ch-pkg_basics.en.html states:
"Extra: packages that either conflict with others with higher
priorities, are only likely to be useful if you already know what they
are [...]"
Perhaps I'm being a newbie, but this sounds a good fit. One would
probably already know of copher if one was going to use it; should it
be in Optional instead?
> > Architecture: any
> > Depends: libwww-mechanize-perl, ${shlibs:Depends}
> The perl script is architecture-dependent, isn't it?
Set architecture to 'all', removed shlibs placeholder.
> > Copher makes a SourceForge release automatically. It is useful as part
> > of a build and release system.
>
> This doesn't really tell me much about Copher; I am the admin of a project
> at sf.net and that description doesn't tell me it could be useful to me.
>
> > of a build and release system. Support for other GForge-based sites is
> > in development.
>
> SF.net is not 'GForge-based', that sentence should be rephrased.
This originally came from the RFP; I have rewritten it into something
more useful.
> debian/copher.1:
Same here, and removed the manpage boilerplate that I overlooked.
> debian/rules:
> debian/compat:
> debian/control:
> You build-depend on debhelper 7 but use none of its features? you
> should/could use a lower compat level such as 5 instead.
Set to 5. Is there anywhere that details the feature in each
compatibility level for future reference?
> debian/dirs:
> file is useless, remove it
>
> $ xlintian -I -E copher*changes
> W: copher: extra-license-file usr/share/doc/copher/COPYING.gz
> I: copher: package-contains-empty-directory usr/sbin/
Gone.
The updated package can be found at:
http://mentors.debian.net/debian/pool/main/c/copher
Thanks for your time and feedbacki.
--
Jonathan Wiltshire
Attachment:
signature.asc
Description: Digital signature