On Thursday 28 August 2008 17:17:20 Stephan Peijnik wrote: > Dear mentors, > > I am looking for a sponsor for the new version 0.4-12 > of my package "netmon-applet". Hello, here are some comments, you might want to address: 1) debian/copyright lacks important information - linux-data.c is copyrighted by another person, but not mentioned in the copyright file. 2) update upstream URL in debian/copyright, or better convert to machine interpretable copyright format [1] 3) code duplication since linux-data.c has been borrowed from xnetload, which is already in Debian -- anti security, but the impact is in fact very low in that case. Btw, why this package should stay in Debian, when we have xnetload, sharing more or less the same functionality ? 4) changes to the upstream code, which are now applied in a combined fashion by diff.gz are best to be broken up in logical diffs and comunicated upstream. No gain in removing unused variables from gnome-ui.c:netmon_draw(), there are quite some more left, so leave them to upstream to clean as they find fit, some like to leave unused vars as a reminder ;-) [1] http://wiki.debian.org/Proposals/CopyrightFormat -- pub 4096R/0E4BD0AB 2003-03-18 <people.fccf.net/danchev/key pgp.mit.edu>
Attachment:
signature.asc
Description: This is a digitally signed message part.