Hi Raphael, Thanks once again for the review. On Fri, 22 Aug 2008 21:09:34 -0500 Raphael Geissert <atomo64+debian@gmail.com> wrote: > A very quick look reveals some inconsistencies between the > Copyright/Upstream information in debian/copyright and the one > available in the .php files. I believe this to just be the name of the primary author and the listing of a secondary author. debian/copyright now contains: Upstream Authors: Nathanael C. Fritz <JID: fritzy@netflint.net> Stephan Wentz <JID: stephan@jabber.wentz.it> Is this the inconsistency of which you were talking, or have I overlooked another? > And, I see you have a patch in debian/patches but you are not > applying it and running the test suite at build time (making the > phpunit b-d completely useless). D'oh! This has been fixed. Thanks to line-ending issues, there is now another patch that is applied before the test fixes so that they apply cleanly. > Please fix those issues and try to examine it by yourself and fix any > issues. I believe this to be a much improved package. It package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/l/libxmpp-php - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/l/libxmpp-php/libxmpp-php_0~svn52-1.dsc Cheers, -- Daniel Watkins (Odd_Bloke)
Attachment:
signature.asc
Description: PGP signature