Hi Laszlo,
Laszlo Boszormenyi ha scritto:
> Just a quick checking:
> - You duplicate php-date, php-mail, php-net-smtp, php-net-ldap and
> php-net-socket packages inside your pacakge. This is a security
> nightmare. Can't you just depend on those packages?
First I tried tu use debian pear linking /usr/share/php to /usr/share/atmailopen/libs/PEAR, but
unfortunately atmail doesn't work, just a white page...
> - Your depends line list sqlite, but why not sqlite3? php5-sqlite
> support both.
Done
> - debian/rules contains some cp commands in the binary-indep target,
> maybe dh_install can handle them.
dh_install cannot rename files or directories, it can only install them with the names they already
have into wherever you want in the package build tree.
So for example install/atmail.mysql will be installed as
usr/share/dbconfig-common/data/atmailopen/install/atmail.mysql, and not as
usr/share/dbconfig-common/data/atmailopen/install/mysql .
Is there a workaround?
> - Why don't you remove empty dirs instead of making lintian override
> them?
I think empty dir could be used, in the code I read for example:
$user['MailDir'] = "{$pref['user_dir']}/users/$first/$second/$this->Account"
> - debian/compat says debhelper level 5, but you build depend on
> debhelper (>= 6) which is well, fine; just inconsistent.
Fixed, debhelper (>= 5)
> - Your diff.gz contains patch-stamp, what for?
Fixed.
Giuseppe.
Attachment:
signature.asc
Description: OpenPGP digital signature