Re: RFS: file-browser-applet

[Andrew <a.starr.b@gmail.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



On Fri, Jun 13, 2008 at 4:45 PM, Vincent Bernat  wrote:
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIU0pbL4k+fGKG+20RAv6HAJwPcz8fl6J8mGmPnJIYRoK67mXW7gCffjAv
wpHBzLN/7xx8EoSfNmqC+jc=
=H587
-----END PGP SIGNATURE-----

>
> In  debian/control,  the  short  description  should not  start  with  a
> upper-case letter. The long description can be shortened by removing the
> last  paragraph. It  is  a duplicate  of  the Homepage  field in  source
> stanza. While you are in  this file, you should update Standards-Version
> to 3.8.0 which was released recently.
>
> In debian/rules,  you should remove commented dh_*  invocations. Some of
> them are useless. For example dh_examples and dh_link.
>

A new version has been uploaded correcting these issue.

> I am not able to compile your package in a clean pbuilder:
> [ 16%] Building C object src/CMakeFiles/file-browser-applet.dir/main.o
> /tmp/buildd/file-browser-applet-0.5.6/src/main.c:26:18: error: glib.h: No such file or directory
> /tmp/buildd/file-browser-applet-0.5.6/src/main.c:27:26: error: glib/gprintf.h: No such file or directory
> /tmp/buildd/file-browser-applet-0.5.6/src/main.c:28:21: error: gtk/gtk.h: No such file or directory
> /tmp/buildd/file-browser-applet-0.5.6/src/main.c:29:35: error: libgnomevfs/gnome-vfs.h: No such file or directory
> /tmp/buildd/file-browser-applet-0.5.6/src/main.c:30:26: error: panel-applet.h: No such file or directory
>
> Maybe there is something broken in Debian since this is exactly the same
> error than for fbreader whose maintainer was seeking for a sponsor here.

I was able to successfully build in an updated sid pbuilder just now.
Hopefully this has been resolved. Maybe a problem in the archive?

Thanks so much for the review Vincent! I really appreciate it...

-Andrew