Re: RFS: fbreader (updated package)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Vincent Bernat wrote:
> Hi Eugene!
Hi, Vincent. Thanks for looking on this package.
> You should use a patch management system. This is easier to track change
> this way. To delete lines from .desktop file, you could also use sed if
> you prefer to not clutter your package with one-liner patch (but patch
> is easier to read and to export).
Ok, will do it.
> I think that long description in debian/control are too short. After
> reading them, I wonder what "zlibrary core" is.
The package was adopted by me recently, and I simply thought not to
change. But I agree with you, will try to substitute description(s) with
more clear one(s).
> You may want to use dh_link to add symbolic links to your
> package. Moreover, I think that the trick that you added at the end of
> debian/rules to satisfy lintian is not needed anymore.
Ok, will look...
> At least, the package does not seem to compile in a freshly updated
> pbuilder:
> make[1]: Entering directory `/tmp/buildd/fbreader-0.8.17/zlibrary/ui'
> Package xcb-renderutil was not found in the pkg-config search path.
> Perhaps you should add the directory containing `xcb-renderutil.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'xcb-renderutil', required by 'cairo', not found
> make[2]: Entering directory `/tmp/buildd/fbreader-0.8.17/zlibrary/ui/src/gtk/time'
> Compiling ZLGtkTime.o ...ZLGtkTime.cpp:20:18: warning: glib.h: No such file or directory
>
> This does not seem to be a missing dependency. I don't have time to
> investigate, but maybe this is related to newly introduced xcb packages?
> Or maybe not.
Hmm... Ok, I will investigate new situation.
When I have fixed all these issues, I'll mail here.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkhSHecACgkQchorMMFUmYy50QCgnXwNMsbkJWE7blseczE1GPiH
TQgAn24WvdFQXpT7dFR/Z+vu74+12Fig
=lmoH
-----END PGP SIGNATURE-----
Reply to: