[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: lockrun

On Thursday 29 May 2008, Noah Slater wrote:
> Hello,
> Thank you all for the suggestions/comments, etc.


> On Sun, May 25, 2008 at 10:43:19AM +0300, George Danchev wrote:
> > I'd rather reply with few questions ;-) -- it seems that the
> > command-option.patch is not applied before building stage causing your
> > help2man call to fail, since the binary knows nothing about --help. What
> > is your idea of how to apply (before building) and unapply (on cleaning)
> > that patch?
> In my debian/rules I have the following line:
>   include /usr/share/cdbs/1/rules/simple-patchsys.mk
> This should automatically apply and clean the patches. It works on my
> system.
> When you debuild it does CDBS not handle patches on your system?
> I am using version 0.4.52 and my package Build-Depends on cdbs (>= 0.4.42).

Sure, the CDBS magic is fine, although being magic behind the scene could be 
dangerous sometimes. It is Debian Policy #4.9 which says: "The binary target 
must be all that is necessary for the user to build the binary package(s) 
produced from this source package". A `must', but `fakeroot debian/rules 
binary' yields:

sed "s/@version@/0~20080520/" < lockrun.c > lockrun.sed.c
cc  lockrun.sed.c -o lockrun
cp lockrun debian/lockrun/usr/bin
help2man -N -n "a cron job overrun protection utility" ./lockrun > lockrun.1
help2man: can't get `--help' info from ./lockrun
make: *** [common-install-prehook-impl] Error 2

Seems like cdbs magic doesn't cope with that, but you can still save the day:
clean:: unpatch
common-install-prehook-impl:: patch

2) Regenerating source files (the sed line) during the build process could be 
a weird source of troubles. Next, we end up having one single C file and two 
ways of modifying it (patch and sed ;-) -- readers won't be impressed by 
that ;-) If you really need that version substitution I suggest to approach 
the upstream to introduce a date/version variable which could be rolled by 
their $VCS of choice or the very developers themselves if no $VCS is being 

3) No diff.gz found on mentors - probably a native package done by incident ?

4) You can add a watch file, also.

pub 4096R/0E4BD0AB 2003-03-18 <people.fccf.net/danchev/key pgp.mit.edu>
fingerprint 1AE7 7C66 0A26 5BFF DF22 5D55 1C57 0C89 0E4B D0AB 

Reply to: