[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: gtk-nodoka-engine



On Thu, 2008-05-29 at 17:59 +0200, Vincent Bernat wrote:
> OoO En  cette fin de nuit blanche  du dimanche 25 mai  2008, vers 05:27,
> Christopher James Halse Rogers <chalserogers@gmail.com> disait:
> 
> > * Package name    : gtk-nodoka-engine
> >   Version         : 0.7.0-1
> >   Upstream Author : Daniel Geiger <dgeiger_343@yahoo.com>, Martin
> > Sourada <martin.sourada@seznam.cz>
> > * URL             : https://hosted.fedoraproject.org/nodoka/wiki
> > * License         : GPLv2+
> >   Section : gnome
> 
> Hi Christopher!
> 
> Please,  add  an  Homepage   field  to  debian/control,  in  the  source
> stanza. 
Fixed.
> Clean up a bit your debian/watch (remove unneeded comments). 
Fixed.
> You
> can also clean up comments in debian/rules (the ones at the top).
Fixed.

> I am not sure of this, but don't you need to use dh_gtkmodules?

My reading of man dh_gtkmodules is that it's for GdkPixbuf loaders or
input modules.  The package works fine for me without, and seems to have
an appropriate dependency on libgtk2.0.  I don't think it's needed, but
anyone with a better understanding please jump in :).

I've also gone back and made the get-orig-source target policy compliant
(able to be run from any directory) with a neat trick I picked up from
Emmet Hickory.

The updated package is now up on mentors.

Thanks very much.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: