Re: RFS: evilvte (updated package) - lightweight terminal emulator
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Bernhard R. Link wrote:
> While your solution works, I'd suggest setting OPTFLAGS
> instead.
Done.
>>> * your debian/rules is not parallel-clean
>>> (i.e. it might fail with -j2)
Fixed.
> More annoying is that it call ./configure from
> "$(MAKE) clean" all the time.
Fixed.
> You should depend on an actually generated file instead
> (best $(QUILT_STAMPFN)).
Done.
> Thus you should use that instead of config.status.
> With those two changes, the program is only build one time.
Done.
> Another little issue: configure calls pkg-config,
> but you do not build-depend on that.
Fixed.
> [1] which you should limit to the actual used parameters really.
Done.
I believe that all the problems has been fixed.
Very thanks to Bernhard R. Link.
The everything-fixed package can be found on mentors.debian.net:
- - dget
http://mentors.debian.net/debian/pool/main/e/evilvte/evilvte_0.4.3-1.dsc
Kind regards
Wen-Yen Chuang (caleb)
- --
My GPG key is signed by Debian Developer Masayuki Hatta.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFIPPs5dEpXpumNYVkRAk2NAJ4mgl5A4vUr9r+EXfvROGB+FhQnbgCggvHw
9f+iQBb76yBUUK8FhMm6ooA=
=4Fvj
-----END PGP SIGNATURE-----
Reply to: