Re: RFS: evilvte (updated package) - lightweight terminal emulator

["Bernhard R. Link" <brlink@debian.org>]

* Wen-Yen Chuang <caleb@calno.com> [080527 11:33]:
> I am looking for a sponsor for the new version 0.4.3-1 of
> my package "evilvte".
> It is lintian clean.
> 
> It builds the binary package:
> evilvte - an VTE based super lightweight terminal emulator
>  evilvte is a terminal emulator. It supports almost everything VTE
>  provides. It also supports tabs, tabbar autohide, and switch encoding
>  at runtime. Configuration is via editing source code and recompilation.
>  .
>  This build provides all runtime changeable options in the right-click
>  menu.
> 
> The package can be found on mentors.debian.net:
> - - dget
> http://mentors.debian.net/debian/pool/main/e/evilvte/evilvte_0.4.3-1.dsc

Some suggestions for improvements:

* your debian/rules is not parallel-clean (i.e. it might fail with -j2),
because "clean: clean1 unpatch" does not express that clean1 should be
called before unpatch.

* it would be nice to have build-indep and build-arch rules, like
build-arch: build-stamp
build-indep:
More packages having them make buildds in some future switch to
build-arch more likely.

* You do not build with the build flags suggested by policy (-O2 -g) but
with -Os. (setting OPTFLAGS in the make call should suffice, but please
also support compiling with -O0 when the correct DEB_BUILD_OPTIONS is
set)

* upstream Makefile has some bug causing the source to be compiled
multiple times (one time in build and again in binary)

Hochachtungsvoll,
	Bernhard R. Link
-- 
"Never contain programs so few bugs, as when no debugging tools are available!"
	Niklaus Wirth