Ruben Molina scrisse: > Dear mentors, > > I am looking for a sponsor for the new version 1.2.0-6 > of the package "xplanet", which I'm adopting. Here's a quick review of your package, which actually isn't in an uploadable state: * Your debian/copyright is lacking large third parties' copyright assignment like The open group (eg. xplanet/rgb.txt), Apple Computer (eg. src/libdisplay/DesktopPicture.m), DEC (eg. src/ParseGeom.h) and other individuals (eg. src/libdisplay/vroot.h). Not everything is under GPL, either. There are some notes about images copyright at xplanet/images/README, you should mention that too. While you're at it, I'd really suggest you to completely refactor your debian/copyright in a more readable manner, collapsing redundant debian packaging notes and mentioning that the upstream download site has been now moved to sourceforge. Also, at your discretion, consider following http://wiki.debian.org/Proposals/CopyrightFormat (which can help you track down the mess :) * You're currently shipping a patch (gcc-4.3-includes) which isn't yet committed to upstream's SVN, please take care of forwarding it now. * What's debian/package.docs for? (Maybe a forgotten example?) * Try lintian with -Ii to see that it suggests that hyphens are wrongly used in the manpage. Otherwise the package looks quite good, and I'll take a deeper look to your fixed package. > Kind regards > Ruben Molina Ciao, Luca -- .''`. ** Debian GNU/Linux ** | Luca Bruno : :' : The Universal O.S. | lucab (AT) debian.org `. `'` | GPG Key ID: 3BFB9FB3 `- http://www.debian.org | Debian GNU/Linux Developer
Attachment:
pgpuzKr_jgXH1.pgp
Description: PGP signature