Re: RFS: mailscanner (updated package)

[Anthony Fok <foka@debian.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Simon,

Simon Walter wrote:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 4.68.8-1
> of my package "mailscanner".
> 
> It builds these binary packages:
> mailscanner - email gateway for virus scanning, spam and phishing detection
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 469916, 472067, 472489, 472676
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/m/mailscanner
> - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/m/mailscanner/mailscanner_4.68.8-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards
>  Simon Walter

I built your package with pdebuild and uploaded it too on April 5th at
around 10 a.m. Beijing time, and apparently it is already in the
mirrors.  Next time I should try to announce it ASAP to avoid
duplication of work.  (Sorry, Noèl!)

I do have a comment about your source mailscanner_4.68.8.orig.tar.gz
though.  The files therein are owned by thargor (your username right?),
so I assume you have repackaged the upstream source tarball yourself.

If I'm not mistaken, the original "pristine" upstream source is this:

 MailScanner-install-4.68.8/perl-tar/MailScanner-4.68.8-1.tar.gz

from

 http://mailscanner.info/files/4/tar/MailScanner-install-4.68.8-1.tar.gz

Since the contents within the upstream MailScanner-4.68.8-1.tar.gz and
your repackaged mailscanner_4.68.8.orig.tar.gz are entirely identical, I
think using pristine source is best practice.  Please read "Section
6.7.8 Best practices for orig.tar.gz files" in the Debian Developer's
Reference:

http://www.debian.org/doc/developers-reference/ch-best-pkging-practices.en.html

MailScanner-install-4.68.8/perl-tar/MailScanner-4.68.8-1.tar.gz file (at
least for 4.68.8 version) fits the criteria for pristine upstream
source, so instead of unpacking it and re-compressing it, I recommend
simply copying or renaming MailScanner-4.68.8-1.tar.gz to
mailscanner_4.68.8.orig.tar.gz .

So yes, for your next upload of new upstream release, please try your
best to use upstream pristine source.  You may want to update
debian/copyright a bit as well (e.g. change 2002-2007 to 2002-2008).

Many thanks!  :-)

Anthony Fok
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH+PKZLa8qZm1n95ARAmVXAJ4lGpBafzBpM76gXWtDFlszyNNhpwCgkULB
jopLGmVJFEMyVb5Go/8mnFs=
=ZUfY
-----END PGP SIGNATURE-----