[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: NMU: rcalc - graphical symbolic calculator

Kevin Coyner wrote:
On Sun, Mar 02, 2008 at 12:46:15AM -0500, Barry deFreese wrote......

Here is another one of my fairly intrusive NMUs.  It fixes RC bug:
#466143 as well as standards and lintian cleanup.


Description: graphical symbolic calculator


Looks good except for two things:

    1. Lots of unneeded whitespace in debian/copyright. Could be
    removed and also removal of comment-out lines in debian/rules.

    2. Perhaps it would be better to have all of the source code
    changes done through dpatch or quilt. I know this is an NMU and
    being unobtrusive is important, but there are quite a few
    upstream source code changes which I think would be better off
    in a patch system.

I'd be willing to upload once these are addressed.



OK, I've updated it.  Let me know if copyright is better now.



Barry deFreese

Reply to: