[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: nettee

On Feb 18, 2008 9:28 PM, Patrick Schoenfeld
<schoenfeld@in-medias-res.com> wrote:

> > - dget http://mentors.debian.net/debian/pool/main/n/nettee/nettee_0.1.8-3.dsc

Some additional comments:

> Now to your package:
> - debian/changelog


> - debian/copyright

Please move <Copyright (C) 2007 David Mathog> onto a line on its own
and remove the weird angle brackets.

The software is GPL2 only, not GPL2 or later.

> - debian/README.Debian: Hm. I'm unsure if the content is suited for
>   README.Debian. Why? Because it seems like it has no documenting
>   character, more beeing an advertising on how enthusiastic you are
>   about the tool ;) I would like to hear other opinions about this,
>   however.

I agree, perhaps this could be placed in the upstream README?

> - debian/rules:

You don't build it with -D_LARGEFILE64_SOURCE, why is that?

It would be good if there were a commented out DH_VERBOSE line in
there to enable easy debugging of debian/rules.

It would be good if you could write a Makefile with the following
targets and send it upstream:

all or build, clean, install, dist.

Be sure to support CFLAGS, PREFIX and DESTDIR in your Makefile since
debian/rules will need them. For extra points it should support
checking for solaris and compiling appropriately (see the comments in

> - debian/watch is missing, but highly recommended. it enables tracking of
>   new upstream versions via your QA page and even a mail notification if
>   you want. See [4] for more information.

debian/docs: No need to distribute empty files nor a HTML copy of the
manual page.

If you want to distribute the pdist scripts, you should at least
customize them by using the right path to nettee. You can do this with
either sed or a patch system like quilt.

Upstream includes the binary in the tarball, please ask them to fix that.



Reply to: