Re: RFS: hashalot (updated)

[Kapil Hari Paranjape <kapil@imsc.res.in>]

Hello,

Some quick comments.

On Thu, 24 Jan 2008, Adam Borowski wrote:
> * Buffer overflow on RMD160:
>   It will cause only a crash instead of executing arbitrary code, and
>   considering the typical usage this is nearly always harmless.  Yet, in
>   non-typical uses even wrong output can be pretty bad for a hash.
> 
>   A nearly-identical fix is already in Ubuntu (they move some functions
>   around without an apparent reason).

Has this patch been submitted upstream?

> * Vcs-Svn and Vcs-Browser.

Shouldn't the Vcs-Svn entry start with "svn:" instead of "http:"?

> As the diff is small (except for file deletions), this shouldn't take much
> of your time.  If someone could upload this, that would be cool.

I will take a more detailed look at it.

Regards,

Kapil.
--