[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: gthumb (updated and adopted package)



Il giorno Wed, 2 Jan 2008 12:02:58 +0100
David Paleino <d.paleino@gmail.com> ha scritto:

> Please don't upload it yet. I've just found out a minor issue during build:
> after svn-buildpackage the sources are left modified. Looking at it right now.

Ok, I can't solve this, thus asking for help.

Upstream's tarball provides a file, src/GNOME_GThumb.h, which is dynamically
generated during the build. Now, it happens that this file, at the end of the
build, is different from the provided one, and $(MAKE) distclean deletes it.
This gives a tarball different from the original one, thus having unmatching
md5sums.

What I've done is:

1) patching the Makefile.{am,in} to make that file stay there after distclean;
2) patching the cited file to "prevent" modifications during the build (it's
just a line removed), so that when the "unpatch" rule does its job, it goes
back to the original file.

These actions did have catastrofic effects: the build fails, looking for a
non-existant file, which is named after a Makefile rule. I can't understand why
make is looking for that file; it is not referenced anywhere, only in that rule
(it's something like "gthumb_sources_idl_stamp"). This is probably due to the
fact that the removed line is:

#line 14 "/usr/share/idl/bonobo-2.0/Bonobo.idl"

Without those patches, it builds just fine, but this is what happens when the
build finishes:

$ svn-buildpackage ...
...
$ svn status
M      src/GNOME_GThumb.h
$

This isn't, obviously, optimal: I'd expect a FTBFS if this package gets
uploaded, and I wouldn't know how to fix it, since I'm not able right now.

Any help? :)

David

-- 
 . ''`.  Debian maintainer |  http://snipurl.com/qa_page
 : :'  :  Linuxer #334216  |  http://www.hanskalabs.net/
 `. `'`    GPG: 1392B174   | http://www.debianizzati.org/
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

Attachment: signature.asc
Description: PGP signature


Reply to: