On Fri, 16 Nov 2007 11:03:52 +0930 "Paul Wise" <pabs@debian.org> wrote: > On Nov 16, 2007 1:50 AM, Manuel Garcia <mannyto@gmail.com> wrote: > > > I am looking for a sponsor for the new version 2.9.0-1 > > of my package "gnomad2". > > A review of your package: > > Might want to add a Homepage: http://wiki.debian.org/HomepageFieldHOWTO > > why not remove this line from debian/rules? > > # -$(MAKE) distclean > > might want to support DEB_BUILD_OPTIONS=noopt in debian/rules > > you don't build with -g so you are not supporting DEB_BUILD_OPTIONS=nostrip > > might want to add support for cross-compiling by adding --build and > --host options to configure: > > DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE) > DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE) > build: > ./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) Paul, please take care recommending that syntax. What should be used is: DEB_HOST_GNU_TYPE=$(shell dpkg-architecture -qDEB_HOST_GNU_TYPE) DEB_BUILD_GNU_TYPE=$(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE) ifneq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE)) CROSS= --build $(DEB_BUILD_GNU_TYPE) --host $(DEB_HOST_GNU_TYPE) else CROSS= --build $(DEB_BUILD_GNU_TYPE) endif ./configure $(CROSS) ... http://wiki.debian.org/EmdebianGuide (also contains an example for packages that use make but not configure) Do *not* pass --host to a native build, it causes the build to look for a cross-compiler. See also: http://lists.debian.org/debian-devel/2007/11/msg00116.html and /usr/share/doc/autotools-dev/README.Debian.gz -- Neil Williams ============= http://www.data-freedom.org/ http://www.nosoftwarepatents.com/ http://www.linux.codehelp.co.uk/
Attachment:
pgp0Dr6LNpyjw.pgp
Description: PGP signature