Re: RFS: gnomad2 (updated package)
On Nov 15, 2007 9:33 PM, Paul Wise <pabs@debian.org> wrote:
> On Nov 16, 2007 1:50 AM, Manuel Garcia <mannyto@gmail.com> wrote:
>
> > I am looking for a sponsor for the new version 2.9.0-1
> > of my package "gnomad2".
>
> A review of your package:
>
> Might want to add a Homepage: http://wiki.debian.org/HomepageFieldHOWTO
Done
> why not remove this line from debian/rules?
>
> # -$(MAKE) distclean
Done
> might want to support DEB_BUILD_OPTIONS=noopt in debian/rules
>
> you don't build with -g so you are not supporting DEB_BUILD_OPTIONS=nostrip
>
> might want to add support for cross-compiling by adding --build and
> --host options to configure:
>
> DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
> DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
> build:
> ./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE)
>
> might want to use the special syntax for sf.net in your watch file
> (see uscan manual page)
Where should i add this variables?
> 435166 is not "please package new upstream release", so don't put it
> on the same line as "New upstream release." in your changelog, instead
> use something like:
>
> * New upstream release. Closes: #446812.
> - provides hints that the user should be in the plugdev group
> (Closes: #435166)
>
> or
>
> * New upstream release. Closes: #446812.
> * Add a README.Debian explaining that users should be in the plugdev
> group (Closes: #435166)
Done
> much of the README file is irrelevant for users of the binary package,
> you might want to use sed to grab the FAQ section, place it in a FAQ
> file and install that instead of README (don't forget to remove the
> FAQ file on clean though).
Where can i find the "FAQ" file syntax? or i just mv README to FAQ and
that´s it?
> There are some relevant lintian warnings/info:
>
> I: gnomad2: desktop-entry-contains-encoding-key
> /usr/share/applications/gnomad2.desktop:24 Encoding
> W: gnomad2: desktop-entry-invalid-category Application
> /usr/share/applications/gnomad2.desktop
I don´t get this, can you point the way to fix it, please?
> W: gnomad2: syntax-error-in-debian-changelog line 34 "unknown
> key-value key Uirgency - copying to XS-Uirgency"
Fixed.
> --
> bye,
> pabs
>
> http://wiki.debian.org/PaulWise
>
>
>
--
Manuel Garcia
Administrador de redes y servidores
Corporacion Lynqus
Debian GNU/Linux 4.1
codename "Lenny"
Reply to: